Bugfix FXIOS-11237-11238 Regression on settings change #24463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicarobinho
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Hey, @lmarceau. I have tested this and it is working. The approach seems to be fine from my perspective because I have started the investigations on this issue but I have not found a fix, yet.
|
@lmarceau, tested, but the height bug is still there. |
PARAIPAN9
approved these changes
Feb 3, 2025
|
Discussed with @PARAIPAN9 and there's another issue with the settings layout which we'll have a different ticket for. |
|
@lmarceau i think this should also be backported to 136. |
|
@Mergifyio backport release/v136 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
With boolean (cherry picked from commit 056b8ba)
6 tasks
lmarceau
added a commit
that referenced
this pull request
Feb 4, 2025
…) (#24534) Bugfix FXIOS-11237-11238 Regression on settings change (#24463) With boolean (cherry picked from commit 056b8ba) Co-authored-by: lmarceau <[email protected]>
aya-en-amir
pushed a commit
to aya-en-amir/firefox-ios
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Ticket 1
Jira ticket
Github issue
Ticket 2
Jira ticket
Github issue
💡 Description
Changes in #24427 caused some regressions. Apparently reloading in
viewWillAppeardoesn't work, butviewDidAppearworks. One way to easily fix is by using a boolean. I am not a fan of this, but without putting too much time this is what I came up with. Let me know if you think of a better way. Tagging @dicarobinho since I saw you assigned yourselves one of the tickets, so maybe you have some ideas. Thank you!📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)