Bugfix FXIOS-11237-11238 Regression on settings change (mozilla-mobil…

…e#24463) With boolean
aya-en-amir · Feb 5, 2025 · f3dee03 · f3dee03
1 parent a270a18
commit f3dee03
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/firefox-ios/Client/Frontend/Settings/Main/AppSettingsTableViewController.swift b/firefox-ios/Client/Frontend/Settings/Main/AppSettingsTableViewController.swift
@@ -51,6 +51,7 @@ class AppSettingsTableViewController: SettingsTableViewController,
     private var applicationHelper: ApplicationHelper
     private let logger: Logger
     private let gleanUsageReportingMetricsService: GleanUsageReportingMetricsService
+    private var hasAppearedBefore = false
 
     weak var parentCoordinator: SettingsFlowDelegate?
 
@@ -97,10 +98,15 @@ class AppSettingsTableViewController: SettingsTableViewController,
         configureAccessibilityIdentifiers()
     }
 
-    override func viewWillAppear(_ animated: Bool) {
-        super.viewWillAppear(animated)
+    override func viewDidAppear(_ animated: Bool) {
+        super.viewDidAppear(animated)
 
-        askedToReload()
+        if hasAppearedBefore {
+            // Only reload if we're returning from a child view
+            askedToReload()
+        }
+
+        hasAppearedBefore = true
     }
 
     // MARK: - Actions