Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-11237-11238 Regression on settings change #24463

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Bugfix FXIOS-11237-11238 Regression on settings change #24463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions firefox-ios/Client/Frontend/Settings/Main/AppSettingsTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class AppSettingsTableViewController: SettingsTableViewController,
private var applicationHelper: ApplicationHelper
private let logger: Logger
private let gleanUsageReportingMetricsService: GleanUsageReportingMetricsService
private var hasAppearedBefore = false

weak var parentCoordinator: SettingsFlowDelegate?

Expand Down Expand Up @@ -97,10 +98,15 @@ class AppSettingsTableViewController: SettingsTableViewController,
configureAccessibilityIdentifiers()
}

override func viewWillAppear(_ animated: Bool) {
super.viewWillAppear(animated)
override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)

askedToReload()
if hasAppearedBefore {
// Only reload if we're returning from a child view
askedToReload()
}

hasAppearedBefore = true
}

// MARK: - Actions
Expand Down