Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-11237-11238 Regression on settings change (backport #24463) #24534

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 4, 2025

📜 Tickets

Ticket 1
Jira ticket
Github issue

Ticket 2
Jira ticket
Github issue

💡 Description

Changes in #24427 caused some regressions. Apparently reloading in viewWillAppear doesn't work, but viewDidAppear works. One way to easily fix is by using a boolean. I am not a fan of this, but without putting too much time this is what I came up with. Let me know if you think of a better way. Tagging @dicarobinho since I saw you assigned yourselves one of the tickets, so maybe you have some ideas. Thank you!

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #24463 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner February 4, 2025 13:41
@mergify mergify bot requested review from mdotb-moz and removed request for a team February 4, 2025 13:41
@dragosb01 dragosb01 requested review from dragosb01 and removed request for dragosb01 February 4, 2025 14:09
@lmarceau lmarceau merged commit d92392b into release/v136 Feb 4, 2025
11 of 12 checks passed
@lmarceau lmarceau deleted the mergify/bp/release/v136/pr-24463 branch February 4, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant