-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HLT menu (V4) [81X] #15875
Update HLT menu (V4) [81X] #15875
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_8_1_X. It involves the following packages: Configuration/HLT @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
'25ns10e33_v2' : ( ','.join( [ 'L1Menu_Collisions2016_v4_xml' ,l1tMenuRecord,connectionString,l1tMenuLabel, "2016-05-24 14:55:00.000"] ), ), | ||
'HIon' : ( ','.join( [ 'L1Menu_CollisionsHeavyIons2015_v5_uGT_xml' ,l1tMenuRecord,connectionString,l1tMenuLabel, "2016-03-04 15:00:00.000"] ), ), | ||
'PIon' : ( ','.join( [ 'L1Menu_Collisions2016_v6_xml' ,l1tMenuRecord,connectionString,l1tMenuLabel, "2016-07-19 10:00:00.000"] ), ), | ||
'PIon' : ( ','.join( [ 'L1Menu_Collisions2016_v6r5_ugt_1board_xml' ,l1tMenuRecord,connectionString,l1tMenuLabel, "2016-08-23 20:00:00.000"] ), ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silviodonato, we are updating in parallel the content of the L1 menu in Global Tag. It would be nice to avoid customization once integrated @franzoni
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marco,, these are the TSG internal GTs where we do that all the time....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Martin-Grunewald so are we expecting this PR to fail the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends: currently the @RelVal still points to the previous menu.
We should probably change it to point to the new frozen menu, and then the relvals
which of course use official GTs will fail until those GTs are updated with the new L1 menu.
How do we proceed? You make new GTs and a PR whose commit we add to this one as in the past?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am updating the GTs in this very moment. I'll notify you once I have the commit done, so that you can cherry-pick it and change the @relval
menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 80 and 81? Given that MC production with the new HLT menu is with 80, and 81 should not lag behind 81....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess your last statement, not to be circular, should read:
81 should not lag behind 80
....
so both, but 81x first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you are willing to do the change #15879 might be interesting for you
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 070a79f The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log1306.0 step2 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log1330.0 step2 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
I found errors in the following addon tests: cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Sep 16 18:27:24 2016-date Fri Sep 16 18:09:59 2016 s - exit: 16640 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
OK, here we point to the development menus which need the new L1T menu in the GTs. |
please cherry pick from #15879 |
-1 Tested at: 070a79f The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log1306.0 step2 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log1330.0 step2 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
I found errors in the following addon tests: cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Sep 16 19:44:19 2016-date Fri Sep 16 19:21:24 2016 s - exit: 16640 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Pull request #15875 was updated. @perrotta, @cmsbuild, @ghellwig, @silviodonato, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich, @davidlange6 can you please check and sign again. |
25266f2
to
b30818f
Compare
Pull request #15875 was updated. @perrotta, @cmsbuild, @ghellwig, @silviodonato, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Rebased to CMSSW_8_1_X_2016-09-18-0000 and including revised #15879 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This PR updates the HLT menus to the most updated version (V4).
HLT master table: /dev/CMSSW_8_0_0/HLT/V536
GRun table: /dev/CMSSW_8_0_0/GRun/V184
All working paths that were removed from GRun have been re-inserted, in order to have them available in the next MC production as requested by XEB.
80X version: #15873