-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HLT menu (V4) [81X] #15875
Merged
cmsbuild
merged 21 commits into
cms-sw:CMSSW_8_1_X
from
cms-tsg-storm:81XHLTAfterMD2Train
Sep 19, 2016
+238,483
−65,297
Merged
Update HLT menu (V4) [81X] #15875
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
431956e
Update HLT menu up to /dev/CMSSW_8_0_0/HLT/V466
perrotta 02fa0ce
Update txt's
perrotta e164716
Update HLT menu up to /dev/CMSSW_8_0_0/HLT/V473
perrotta 960a69b
Remove paths from CMSHLT-981 from GRun
perrotta efe1d92
Update HLT menu up to /dev/CMSSW_8_0_0/HLT/V478
perrotta 6996ab1
Update HLT menu up to /dev/CMSSW_8_0_0/HLT/V484
perrotta 04bbfc7
Update HLT menu up to /dev/CMSSW_8_0_0/HLT/V485 and L1 menu as Global…
perrotta 569bde5
Migration for and including CMSHLT-984
Martin-Grunewald b436fde
Update HLT menu up to /dev/CMSSW_8_0_0/HLT/V488
perrotta 3acea80
Migration / ESInputTag fix / devel
Martin-Grunewald deb5b7d
Customisation for #15499 (81X only)
Martin-Grunewald c7f14bd
HLT development
Martin-Grunewald 6569160
HLT development
Martin-Grunewald 493d785
HLT V4 menu
silviodonato 9f24e73
Fix customisation
Martin-Grunewald efaf0ee
Fix the customisation fix
Martin-Grunewald 7b0230c
final HLT V4 menu
silviodonato e434ebf
fix on tau triggers, again
silviodonato c96f037
sync with V536
silviodonato 8ff712e
Add new frozen menu 25ns15e33_v4
Martin-Grunewald b30818f
Picking from #15879
mmusich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silviodonato, we are updating in parallel the content of the L1 menu in Global Tag. It would be nice to avoid customization once integrated @franzoni
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marco,, these are the TSG internal GTs where we do that all the time....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Martin-Grunewald so are we expecting this PR to fail the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends: currently the @RelVal still points to the previous menu.
We should probably change it to point to the new frozen menu, and then the relvals
which of course use official GTs will fail until those GTs are updated with the new L1 menu.
How do we proceed? You make new GTs and a PR whose commit we add to this one as in the past?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am updating the GTs in this very moment. I'll notify you once I have the commit done, so that you can cherry-pick it and change the
@relval
menu.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 80 and 81? Given that MC production with the new HLT menu is with 80, and 81 should not lag behind 81....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess your last statement, not to be circular, should read:
....
so both, but 81x first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you are willing to do the change #15879 might be interesting for you