Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLT menu (V4) #15873

Merged
merged 30 commits into from
Sep 22, 2016
Merged

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Sep 16, 2016

This PR updates the HLT menus to the most updated version (V4).
HLT master table: /dev/CMSSW_8_0_0/HLT/V536
GRun table: /dev/CMSSW_8_0_0/GRun/V184

All working paths that were removed from GRun have been re-inserted, in order to have them available in the next MC production as requested by XEB.

81X version: #15875

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_8_0_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15192/console

@fwyzard
Copy link
Contributor

fwyzard commented Sep 16, 2016

@silviodonato , we also need to "freeze" the new HLT menu to make it available for relvals and MC production.

Can you

  • update /frozen/2016/25ns15e33/v4.0/HLT to the latest GRun menu
  • include it in the python dumps, as HLTrigger/Configuration/python/HLT_25ns15e33_v4_cff.py
    ?

@cmsbuild
Copy link
Contributor

Pull request #15873 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #15873 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15208/console

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Sep 16, 2016

please do not interfere.... because your latest commit will break things

@cmsbuild
Copy link
Contributor

-1

Tested at: 2131b68

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2131b68
ad8f002
2691607
ef88c58
b3ace60
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15873/15208/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15873/15208/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15873/15208/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log
1306.0 step2
runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
135.4 step1
runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
1330.0 step2
runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
25202.0 step2
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
  • AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Sep 16 18:57:22 2016-date Fri Sep 16 18:45:06 2016 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2131b68
ad8f002
2691607
ef88c58
b3ace60
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15873/15208/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15873/15208/git-merge-result

@cmsbuild
Copy link
Contributor

Pull request #15873 was updated. @perrotta, @cmsbuild, @ghellwig, @silviodonato, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @mmusich, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15256/console

@Martin-Grunewald
Copy link
Contributor

Rebased to CMSSW_8_0_X_2016-09-18-0000

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1
@mmusich @cerminar
please sign this one for AlCa as well.

@mmusich
Copy link
Contributor

mmusich commented Sep 19, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 20f2ccc into cms-sw:CMSSW_8_0_X Sep 22, 2016
@Martin-Grunewald Martin-Grunewald deleted the 80XHLTAfterMD2Train branch December 8, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants