Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating in all the relevant Global Tags the L1 menu to the version for post-TS2 data-taking: L1Menu_Collisions2016_v6r5_ugt_1board_xml #15879

Closed

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 16, 2016

Summary of changes in Global Tags

RunII simulation

RunII data

Upgrade

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_1_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor Author

mmusich commented Sep 16, 2016

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Sep 16, 2016
Martin-Grunewald pushed a commit to cms-tsg-storm/cmssw that referenced this pull request Sep 17, 2016
@Martin-Grunewald
Copy link
Contributor

There is a merge conflict in this PR. I do not know whether I picked correctly for HLT...

@Martin-Grunewald
Copy link
Contributor

I have reverted what I picked previously as it gave a merge-conflict as well.
I assume you'd need to update this PR and then I pick again??

@mmusich mmusich force-pushed the 81X_updateGTs_postTS2_L1Menu branch from d708c30 to be9a8f5 Compare September 17, 2016 08:24
@cmsbuild
Copy link
Contributor

Pull request #15879 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich mmusich force-pushed the 81X_updateGTs_postTS2_L1Menu branch from be9a8f5 to b0f3371 Compare September 17, 2016 08:30
@cmsbuild
Copy link
Contributor

Pull request #15879 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

…or post-TS2 data-taking: L1Menu_Collisions2016_v6r5_ugt_1board_xml
@mmusich mmusich force-pushed the 81X_updateGTs_postTS2_L1Menu branch from b0f3371 to 3c08282 Compare September 17, 2016 08:37
@cmsbuild
Copy link
Contributor

Pull request #15879 was updated. @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 17, 2016

@Martin-Grunewald, yes I placed yesterday another PR to grant Hcal people a new key in autoCond #15884 and didn't want to mix them up to create unnecessary dependencies.
Either one of the two had to be merged first and you lost :)
That's sort of inevitable if people place their PRs at the very last minute before the release closes...
Now it merges. Enjoy

Martin-Grunewald pushed a commit to cms-tsg-storm/cmssw that referenced this pull request Sep 18, 2016
@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2016

unhold

@cmsbuild cmsbuild removed the hold label Sep 20, 2016
@mmusich
Copy link
Contributor Author

mmusich commented Sep 20, 2016

+1
change already included in #15875

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15293/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

already merged (with a different commit?) -closing to avoid potential conflicts

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2016

@davidlange6, thanks.
I am not sure why the commit hash of the PR #15875 (b30818f) is different from 3c08282 of this PR, but the changes are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants