-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates from bedrock #456
Updates from bedrock #456
Conversation
From file changes in mozilla/bedrock@bafed7c
-brand-name-mozilla-ai = Mozilla AI | ||
-brand-name-mozilla-ai = Mozilla.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these trigger updates in Pontoon? (I'm not sure whether brands/"terms" also need versioning, or all the strings using them will pick up the change nonetheless?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these trigger updates in Pontoon? (I'm not sure whether brands/"terms" also need versioning, or all the strings using them will pick up the change nonetheless?)
Looks like most of the locales "have translated" the term in the brands.ftl file. Typically, once the string is translated, changes in the source string won't trigger a replacement such as this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the best approach to correct this name? Should I add the corrected name as a new string with -v2
on the ID and mark the old one as obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either that, or I manually go through all the strings that are already "translated" and update them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@craigcook I will go ahead and merge this. If there is no simple way of fixing it, I will fix them one by one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've versioned the string, and that will land shortly. No need to manually fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That requires versioning and updating also all the strings referencing that term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, so far it's only in use in two places and we've updated them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you decided to replace existing translations, there's a branch to create a PR from (but also heading offline).
From file changes in mozilla/bedrock@da85975
From file changes in mozilla/bedrock@04f49f1
From file changes in mozilla/bedrock@bafed7c