Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from bedrock #456

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Updates from bedrock #456

merged 3 commits into from
Dec 4, 2024

Conversation

MozmarRobot
Copy link
Collaborator

From file changes in mozilla/bedrock@bafed7c

@MozmarRobot MozmarRobot requested a review from a team as a code owner December 3, 2024 03:21
-brand-name-mozilla-ai = Mozilla AI
-brand-name-mozilla-ai = Mozilla.ai
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these trigger updates in Pontoon? (I'm not sure whether brands/"terms" also need versioning, or all the strings using them will pick up the change nonetheless?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these trigger updates in Pontoon? (I'm not sure whether brands/"terms" also need versioning, or all the strings using them will pick up the change nonetheless?)

Looks like most of the locales "have translated" the term in the brands.ftl file. Typically, once the string is translated, changes in the source string won't trigger a replacement such as this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's the best approach to correct this name? Should I add the corrected name as a new string with -v2 on the ID and mark the old one as obsolete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either that, or I manually go through all the strings that are already "translated" and update them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigcook I will go ahead and merge this. If there is no simple way of fixing it, I will fix them one by one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've versioned the string, and that will land shortly. No need to manually fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That requires versioning and updating also all the strings referencing that term.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, so far it's only in use in two places and we've updated them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you decided to replace existing translations, there's a branch to create a PR from (but also heading offline).

@peiying2 peiying2 merged commit d565912 into master Dec 4, 2024
2 checks passed
@peiying2 peiying2 deleted the update-from-bedrock-bafed7c7 branch December 4, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants