Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from bedrock #456

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Updates from bedrock #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7976c1e
Updates from bedrock
MozmarRobot Dec 3, 2024
efba73e
Updates from bedrock
MozmarRobot Dec 4, 2024
de00615
Updates from bedrock
MozmarRobot Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion en/brands.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
-brand-name-mozilla-account = Mozilla account
-brand-name-mozilla-accounts = Mozilla accounts
-brand-name-mozilla-social = Mozilla.social
-brand-name-mozilla-ai = Mozilla AI
-brand-name-mozilla-ai = Mozilla.ai
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these trigger updates in Pontoon? (I'm not sure whether brands/"terms" also need versioning, or all the strings using them will pick up the change nonetheless?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these trigger updates in Pontoon? (I'm not sure whether brands/"terms" also need versioning, or all the strings using them will pick up the change nonetheless?)

Looks like most of the locales "have translated" the term in the brands.ftl file. Typically, once the string is translated, changes in the source string won't trigger a replacement such as this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's the best approach to correct this name? Should I add the corrected name as a new string with -v2 on the ID and mark the old one as obsolete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either that, or I manually go through all the strings that are already "translated" and update them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigcook I will go ahead and merge this. If there is no simple way of fixing it, I will fix them one by one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've versioned the string, and that will land shortly. No need to manually fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That requires versioning and updating also all the strings referencing that term.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, so far it's only in use in two places and we've updated them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you decided to replace existing translations, there's a branch to create a PR from (but also heading offline).

-brand-name-mozilla-ventures = Mozilla Ventures
-brand-name-rise25 = Rise25
-brand-name-thunderbird = Thunderbird
Expand Down
2 changes: 2 additions & 0 deletions en/footer-refresh.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,5 @@ footer-refresh-websites-legal = Legal
footer-refresh-community-participation-guidelines = Community Participation Guidelines
footer-refresh-about-this-site = About this site
footer-refresh-language = Language
footer-refresh-primary-nav-aria-label = Footer primary
footer-refresh-secondary-nav-aria-label = Footer secondary
4 changes: 3 additions & 1 deletion en/mozorg/home-m24.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ m24-home-mozilla-vpn = { -brand-name-mozilla-vpn }
m24-home-keep-your-location = Keep your location and online adventures private — stream like a local, anywhere.
m24-home-mozilla-monitor = { -brand-name-mozilla-monitor }
m24-home-get-a-headsup = Get a heads-up if your personal info is at risk and lock it down like a pro.
m24-home-firefox-relay = { -brand-name-firefox-relay }
m24-home-mask-your-email = Mask your email and phone number so you only get the messages you want.

## Donate

Expand All @@ -55,7 +57,7 @@ m24-home-explore-mozilla-ai = Explore { -brand-name-mozilla-ai }
m24-home-llamafile = { -brand-name-llamafile }
m24-home-run-large-language = Run large language models (LLMs) easily on your computer with { -brand-name-llamafile } — no installation needed, and your data stays safe on your device.
m24-home-mozilla-builders= { -brand-name-mozilla } Builders
m24-home-turn-your-ai = Turn your AI idea into reality with our 12-week accelerator. Get funding, mentorship and a chance to pitch your innovation to investors.
m24-home-builders-helps-independent = Builders helps independent developers create transformative open-source AI projects through bespoke collaborations, programming, and community.
m24-home-lumigator = { -brand-name-lumigator}
m24-home-find-the-just = Find the right LLM for your needs, use case and data.
m24-home-can-ai-be = Can AI be trustworthy?
Expand Down
Loading