Refresh: nav tweaks [fix #15564] #15617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcook
added
Needs Review
craigcook
commented
Dec 2, 2024
| @@ -141,6 +141,10 @@ $margin-top: 54px; // top margin offset for mobile navigation menu | |||
| } | |||
| } | |||
|
|
|||
| [dir='rtl'].js .m24-c-navigation-menu-button { | |||
There was a problem hiding this comment.
This was necessary because the direction is applied to the same element that gets the .js class, so the bidi() mixin wasn't really working. It could be fixed more properly with some further refactoring of the CSS but this was a quick hack.
* Change Mozilla AI to Mozilla.ai [fix mozilla#15606] * Add Relay to products list [fix mozilla#15586] * Update close button style * Constrain dropdown width * Add transition to all category link arrow * Remove underlines from links (hover only) * Fix mobile category titles * Use small icons * RTL fixes
craigcook
force-pushed
the
15564-m24-nav-tweaks
branch
from
699943c to
8e1eee3
Compare
janbrasna
reviewed
Dec 4, 2024
| -brand-name-mozilla-ai = Mozilla AI | ||
| -brand-name-mozilla-ai = Mozilla.ai |
There was a problem hiding this comment.
@craigcook This will need to be versioned(?) mozilla-l10n/www-l10n#456 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Issue / Bugzilla link
#15564
#15586
#15606
Testing
Make sure the main nav looks right and isn't broken?