Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3584] Add zod schemas for app metadata living in config.json #14808

Open
joeauyeung opened this issue Apr 30, 2024 · 15 comments · May be fixed by #18750
Open

[CAL-3584] Add zod schemas for app metadata living in config.json #14808

joeauyeung opened this issue Apr 30, 2024 · 15 comments · May be fixed by #18750
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request ✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Comments

@joeauyeung
Copy link
Contributor

joeauyeung commented Apr 30, 2024 •
edited
Loading

When an app's metadata lives in a config.json file we lose typing. Instead we should have a zod schema similar to our AppMeta type that can parse the json file and give us proper typing.

From SyncLinear.com | CAL-3584
@joeauyeung joeauyeung added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers labels Apr 30, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Apr 30, 2024
@hemantwasthere
Copy link

Hey @joeauyeung, I would like to work on this issue

@sotayamashita sotayamashita mentioned this issue May 1, 2024
Closed
11 tasks
@sotayamashita
Copy link

@hemantwasthere
I created the PR experimentally and accidentally linked the issue. you can ignore my PR.
I am sorry for the confusion

@Deep512
Copy link

Deep512 commented May 3, 2024

@joeauyeung @sotayamashita
I am unable to grasp the complete requirement of this issue and also can't open these links here

From SyncLinear.com | CAL-3584

So can you give a brief description of what exactly is required here?

@joeauyeung
Copy link
Contributor Author

@joeauyeung @sotayamashita I am unable to grasp the complete requirement of this issue and also can't open these links here

From SyncLinear.com | CAL-3584

So can you give a brief description of what exactly is required here?

Sorry about that. I just updated the description.

This was referenced May 9, 2024
Closed
Closed
@dosubot dosubot bot added this to the v4.2 milestone May 15, 2024
@keithwillcode keithwillcode modified the milestones: v4.2, v4.4 Jun 17, 2024
@joeauyeung joeauyeung modified the milestones: v4.4, v4.5 Jul 17, 2024
@Koder-academy60
Copy link

Can you please assign this issue to me

@keithwillcode keithwillcode modified the milestones: v4.5, v4.6 Sep 15, 2024
@joeauyeung joeauyeung modified the milestones: v4.6, Community Only Sep 24, 2024
@Shivansh12t
Copy link

Hey @joeauyeung, I would like to work on this issue

@v-a14
Copy link

v-a14 commented Oct 23, 2024

Hey, is anyone working on this issue, if not, please assign me this issue ?

@PaulZeliq
Copy link

I’m interested in this one.

@ANKITSINGH065
Copy link

Hii @joeauyeung , Can i work on this issue

@realAbhi-web
Copy link

attempt

@realAbhi-web realAbhi-web mentioned this issue Nov 17, 2024
Closed
6 tasks
@PeerRich PeerRich added the community Created by Linear-GitHub Sync label Nov 24, 2024
jenilsavani9 added a commit to jenilsavani9/cal.com that referenced this issue Nov 28, 2024
@jenilsavani9
[CAL-3584] Added zod schemas for app metadata living in config.json c…
4ab44c4 
…alcom#14808
@jenilsavani9 jenilsavani9 mentioned this issue Nov 28, 2024
Open
3 tasks
@PeerRich PeerRich removed this from the Community Only milestone Nov 29, 2024
@krishnaGauss
Copy link

Hi @joeauyeung i would like to work on this issue

@pavitrapandey
Copy link

pavitrapandey commented Dec 17, 2024 •
edited
Loading

I can fix it..
can you assign it to me..?

@Himanshu-Joshi45
Copy link

I can fix it.

AritraDey-Dev added a commit to AritraDey-Dev/cal.com that referenced this issue Jan 6, 2025
@AritraDey-Dev
fix: Add zod schemas for app metadata living in config.json
b8f8cbc 
Fixes calcom#14808

Add zod schemas for app metadata in `config.json`.

* Import `appDataSchemas` and `appKeysSchemas` from `apps.schemas.generated` in `packages/app-store/appStoreMetaData.ts`.
* Use `appDataSchemas` and `appKeysSchemas` to parse the metadata in `packages/app-store/appStoreMetaData.ts`.
* Update the `appStoreMetadata` object to use the parsed metadata in `packages/app-store/appStoreMetaData.ts`.
* Import `appDataSchemas` and `appKeysSchemas` from `apps.schemas.generated` in `packages/app-store/getNormalizedAppMetadata.ts`.
* Use `appDataSchemas` and `appKeysSchemas` to parse the metadata in `packages/app-store/getNormalizedAppMetadata.ts`.
* Update the `getNormalizedAppMetadata` function to use the parsed metadata in `packages/app-store/getNormalizedAppMetadata.ts`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/calcom/cal.com/issues/14808?shareId=XXXX-XXXX-XXXX-XXXX).
@AritraDey-Dev AritraDey-Dev mentioned this issue Jan 6, 2025
Closed
@AritraDey-Dev
Copy link

I have created the pr which fixes the issue.Please review my PR and inform if any changes required.

@Jvald27
Copy link

Jvald27 commented Jan 17, 2025 •
edited
Loading

still open? /assign please TEAM 5 (5 individuals)

@YashShelar04 YashShelar04 linked a pull request Jan 19, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request ✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Milestone
No milestone