-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-store): add Zod schema for config.json metadata validation #14824
feat(app-store): add Zod schema for config.json metadata validation #14824
Conversation
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. What is telemetry?This package contains telemetry which tracks how it is used. Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
da32aad
to
93eaa7c
Compare
What does this PR do?
This PR introduces Zod schema validation for app metadata within
config.json
files in the Cal.com repository. The addition of these schemas ensures that the app metadata is correctly typed and validated, preventing potential issues related to data structure inconsistencies.Fixes
Requirement/Documentation
No additional requirements or documentation updates are needed for this change. The implementation follows the existing patterns within the Cal.com codebase.
Type of change
How should this be tested?
add-zod-schema-for-config-metadata
.yarn install
to ensure all dependencies are up to date.yarn test
within thepackages/app-store/zod
directory to verify the Zod schemas.No environment variables or minimal test data are required. The expected outcome is that all unit tests pass, confirming the validity of the Zod schemas.
Mandatory Tasks
Checklist