-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added zod schema #17694
feat: Added zod schema #17694
Conversation
@realAbhi-web is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/17/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (11/17/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (11/17/24)1 label was added to this PR based on Keith Williams's automation. |
@hariombalhara Can you please take a look at this one? |
@realAbhi-web Thanks for the PR 🙏 Could you take a look at this comment and see if it would improve things and is doable or not? |
i looked at your comment, i didn't completly grasp the idea of what you were guiding for can you explain in detail, I will try my best but still i am a newbie |
Hey, so the requirement is to have type safety for config.json. We could do it in 2 ways I believe
|
Closing this PR since is not the meeting our current requirements. Feel free re-open once feedback is addressed. 🙏 |
What does this PR do?
Added Zod Schema to validate and parse app metadata stored in
config.json
to ensure consistency and better error handling.-GitHub issue number - #14808
Mandatory Tasks (DO NOT REMOVE)
I have self-reviewed the code (A decent size PR without self-review might be rejected).
yes
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
no
I confirm automated tests are in place that prove my fix is effective or that my feature works.
yes
How should this be tested?
The schema should validate the config.json and pass without errors if the metadata is correct.
no
Checklist
I haven't read the contributing guide
yes
My code doesn't follow the style guidelines of this project
no
I haven't commented my code, particularly in hard-to-understand areas
yes
I haven't checked if my changes generate no new warnings
yes