fix: Add zod schemas for app metadata living in config.json #18466
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes calcom#14808 Add zod schemas for app metadata in `config.json`. * Import `appDataSchemas` and `appKeysSchemas` from `apps.schemas.generated` in `packages/app-store/appStoreMetaData.ts`. * Use `appDataSchemas` and `appKeysSchemas` to parse the metadata in `packages/app-store/appStoreMetaData.ts`. * Update the `appStoreMetadata` object to use the parsed metadata in `packages/app-store/appStoreMetaData.ts`. * Import `appDataSchemas` and `appKeysSchemas` from `apps.schemas.generated` in `packages/app-store/getNormalizedAppMetadata.ts`. * Use `appDataSchemas` and `appKeysSchemas` to parse the metadata in `packages/app-store/getNormalizedAppMetadata.ts`. * Update the `getNormalizedAppMetadata` function to use the parsed metadata in `packages/app-store/getNormalizedAppMetadata.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/calcom/cal.com/issues/14808?shareId=XXXX-XXXX-XXXX-XXXX).
|
@AritraDey-Dev is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
Low priority
dosubot
bot
added
app-store
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/06/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/06/25)1 label was added to this PR based on Keith Williams's automation. |
Praashh
suggested changes
Jan 6, 2025
There was a problem hiding this comment.
Hey @AritraDey-Dev , unit tests are failing, can you please fix this 🙏
|
Don't get your solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14808
Add zod schemas for app metadata in
config.json.appDataSchemasandappKeysSchemasfromapps.schemas.generatedinpackages/app-store/appStoreMetaData.ts.appDataSchemasandappKeysSchemasto parse the metadata inpackages/app-store/appStoreMetaData.ts.appStoreMetadataobject to use the parsed metadata inpackages/app-store/appStoreMetaData.ts.appDataSchemasandappKeysSchemasfromapps.schemas.generatedinpackages/app-store/getNormalizedAppMetadata.ts.appDataSchemasandappKeysSchemasto parse the metadata inpackages/app-store/getNormalizedAppMetadata.ts.getNormalizedAppMetadatafunction to use the parsed metadata inpackages/app-store/getNormalizedAppMetadata.ts.For more details, open the Copilot Workspace session.