Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): use the renamed API group for incubator package #968

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 7, 2023

What this PR does / why we need it:

Aligns the API group name for KongServiceFacade RBAC rules so it's matching after the rename Kong/kubernetes-ingress-controller#5302. Releases a kong/kong 2.33.1 patch.

Which issue this PR fixes

Part of Kong/kubernetes-ingress-controller#5152.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo self-assigned this Dec 7, 2023
@czeslavo czeslavo force-pushed the fix/facade-api-group branch from 4ca93c3 to 179a630 Compare December 7, 2023 10:52
@czeslavo czeslavo force-pushed the fix/facade-api-group branch from 179a630 to c255c3d Compare December 7, 2023 10:53
@czeslavo czeslavo marked this pull request as ready for review December 7, 2023 10:54
@czeslavo czeslavo requested a review from a team as a code owner December 7, 2023 10:54
@czeslavo czeslavo enabled auto-merge (squash) December 7, 2023 10:57
@czeslavo czeslavo added the bug Something isn't working label Dec 7, 2023
@czeslavo czeslavo merged commit f4246a8 into main Dec 7, 2023
22 checks passed
@czeslavo czeslavo deleted the fix/facade-api-group branch December 7, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants