docs: add KongServiceFacade docs and examples #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
docs/kong-service-facade
branch
from
0049594 to
a3e2379
Compare
czeslavo
force-pushed
the
docs/kong-service-facade
branch
from
a3e2379 to
904aabf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5298 +/- ##
=======================================
- Coverage 75.9% 75.8% -0.1%
=======================================
Files 170 170
Lines 19458 19447 -11
=======================================
- Hits 14769 14756 -13
- Misses 3858 3860 +2
Partials 831 831 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
docs/kong-service-facade
branch
from
904aabf to
5d578c2
Compare
czeslavo
force-pushed
the
docs/kong-service-facade
branch
from
5d578c2 to
d4a46ee
Compare
czeslavo
force-pushed
the
docs/kong-service-facade
branch
from
d4a46ee to
19e3059
Compare
mheap
reviewed
Dec 6, 2023
mheap
reviewed
Dec 6, 2023
czeslavo
force-pushed
the
docs/kong-service-facade
branch
3 times, most recently
from
14bb238 to
506c2cf
Compare
czeslavo
force-pushed
the
docs/kong-service-facade
branch
from
506c2cf to
fca78c7
Compare
mflendrich
reviewed
Dec 8, 2023
Co-authored-by: Michał Flendrich <[email protected]>
|
@mheap @mflendrich Thanks for your comments, PTAL again 👍 |
mheap
approved these changes
Dec 11, 2023
mflendrich
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new
FEATURE_GATES.mdsection "Using KongServiceFacade" explaining the basics ofKongServiceFacade. It also references a new example manifest that demonstrates complete usage ofKongServiceFacadeto set a different set of plugins for the same KubernetesService.The instructions in the example manifest depend on Kong/charts#963 which adds RBACs for
KongServiceFacade.PR also adds an integration test that verifies the new example manifest to make sure it doesn't get outdated.
Which issue this PR fixes:
Closes #5152.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR