Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): use the renamed API group for incubator package #968

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix(controller): use the renamed API group for incubator package #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/kong/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Changelog

## 2.33.1

### Fixed

* Use changed `incubator.ingress-controller.konghq.com` API group name in `KongServiceFacade`
RBAC rules. Refer to [KIC#5302](https://github.com/Kong/kubernetes-ingress-controller/pull/5302)
for rename reasoning.
[#968](https://github.com/Kong/charts/pull/968)

## 2.33.0

### Improvements
Expand Down
2 changes: 1 addition & 1 deletion charts/kong/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ maintainers:
name: kong
sources:
- https://github.com/Kong/charts/tree/main/charts/kong
version: 2.33.0
version: 2.33.1
appVersion: "3.5"
dependencies:
- name: postgresql
Expand Down
4 changes: 2 additions & 2 deletions charts/kong/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,15 +1266,15 @@ resource roles into their separate templates.
{{- if and (semverCompare ">= 3.1.0" (include "kong.effectiveVersion" .Values.ingressController.image))
(contains (print .Values.ingressController.env.feature_gates) "KongServiceFacade=true") }}
- apiGroups:
- incubator.konghq.com
- incubator.ingress-controller.konghq.com
resources:
- kongservicefacades
verbs:
- get
- list
- watch
- apiGroups:
- incubator.konghq.com
- incubator.ingress-controller.konghq.com
resources:
- kongservicefacades/status
verbs:
Expand Down
Loading