Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests requiring USC that supports Sierra 1.7.0 #680

Open
FabijanC opened this issue Jan 15, 2025 · 8 comments · May be fixed by #697
Open

Failing tests requiring USC that supports Sierra 1.7.0 #680

FabijanC opened this issue Jan 15, 2025 · 8 comments · May be fixed by #697
Assignees
Labels
testing Related to code testing

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Jan 15, 2025

Currently our integration forking tests are failing because Devnet can't handle the latest Sierra artifacts. This is the reported error:

Sierra compilation error: Unable to compile Sierra to Casm. No matching ContractClass or CasmContractClass found for version 1.7.0: undefined

A new version of USC should help. Waiting for:

@FabijanC FabijanC added the testing Related to code testing label Jan 15, 2025
@FabijanC FabijanC self-assigned this Jan 15, 2025
FabijanC added a commit that referenced this issue Jan 15, 2025
* [skip ci] - currently failing due to #680

* Increase BackgroundDevnet max_retries: 40 -> 60

* Extract sleeping logic in timestamp tests; extend to 1.1 s
@FabijanC
Copy link
Contributor Author

FabijanC commented Jan 17, 2025

I am not able to resolve the issue by simply updating USC to 2.4.0-rc.0

  • blockifier v0.8.0 (currently specified as a Devnet dependency), doesn't work with cairo-lang* packages required by USC 2.4.0-rc.0.
  • Even upgrading blockifier can't help
    • Currently on the latest commit of their 0.13.4 development branch it specifies cairo-lang-* packages of version 2.10.0-rc.0
    • USC specifies 2.10.0-rc.1
    • So from my understanding, even updating to the latest blockifier dev branch commit won't help until they update their dependencies

Temporary workaround, merged into main : #684

@gaetbout
Copy link

gm,

wondering if this possible now without using the fork flag? :)

@FabijanC
Copy link
Contributor Author

gm,

wondering if this possible now without using the fork flag? :)

If what is possible? Running into this issue?

@gaetbout
Copy link

gaetbout commented Jan 23, 2025

To use the devnet with SIERRA 1.7.0.
Trying to declare some contracts compiled using https://github.com/starkware-libs/cairo/releases/tag/v2.10.0-rc.1

@FabijanC
Copy link
Contributor Author

FabijanC commented Jan 23, 2025

Not possible to declare Sierra 1.7.0 contracts until Devnet's USC (Universal Sierra Compiler) dependency is updated. We are working to resolve this, but it also requires updating the blockifier dependency to the latest version, which is much harder.

@FabijanC
Copy link
Contributor Author

Good news is that a stable blockifier has just been released and we are working to integrate that and the latest USC in Devnet.

@stefanMadzharov
Copy link

Is there any workaround while waiting for the PR to be merged?

@FabijanC
Copy link
Contributor Author

You are advised to use the development branch starknet-0.13.4 which also contains this fix. The plan is to merge that branch into main. However, the branch comes with an update of JSON-RPC API to v0.8.0-rc.3, update of Rust to 1.83 and update of Starknet to 0.13.4.

@FabijanC FabijanC linked a pull request Feb 26, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to code testing
Projects
Status: 🆕 New
3 participants