Update to Starknet 0.13.4 (including RPC 0.8) #697
+14,750
−8,436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change L1 hash repr: bytes array and string -> H256
* Move and rename tx status struct; add failure_reason * Rename InsufficientMaxFee to InsufficientResourcesForValidate * Improve panicking_contract: compile with 2.8.0, add method for distant panic
* SimulateTransactions integration tests (#628) * remove handle_transaction_result, refactor errors * integration tests * added new error type * typo * fixed unit tests * fixed integration test * remove fully qualified names in errors file * changed test name * reuse variable * replace declare_deploy_v1 with declare_v3_deploy_v3 * add simulate transaction validation check * add functionality * refactor if else with match * remove trait implementation * changed error variant * commment * resolve compilation errors * fix integration tests * clippy * removed let [skip ci] * removed duplicated method [skip ci] * remove duplicated test [skip ci] * clippy * clippy [skip ci]
* functions for compiling sierra to casm * removed calculate_casm_hash function * added getCompiledCasm endpoint * change used function for compiling FlattenedSierraClass to Casm * integration tests [skip ci] * Reverted changes * clippy * added check in test * change check in test
* Do interval block creation via request
This reverts commit c096337. * [skip ci]
* SubscriptionNotification refactored, renamed SubscriptionNotification to NotificationData * [skip ci] - we know it's still failing due to old dependencies --------- Co-authored-by: FabijanC <[email protected]>
* [WIP] - todo! in the code * [skip ci]
* [skip ci]
* add l2 gas cli * format cli help text * changes in gas * format * clippy * format * remove debug statement [skip ci] * reduce line count [skip ci] * format [skip ci] * use default l2 gas price [skip ci] * refactored gas_bounds_valid * rename variable in test * added comment * renamed constants [skip ci] * test adaptation [skip ci] * edited devnet spec * formatting * edited docs [skip ci]
10 tasks
3 tasks
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* Use starknet-api hashing logic instead of copied starknet-rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md