Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable early exiting if BackgroundDevnet fails #683

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

FabijanC
Copy link
Contributor

Usage related changes

Hopefully none.

Development related changes

  • Change order of actions in main:
    • Perform port binding after creating Starknet and Api objects (Starknet creation might fail).
  • If BackgroundDevnet fails, early exiting is enabled in port search to prevent unnecessary waiting for 30 seconds.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC added enhancement New feature or request testing Related to code testing labels Jan 16, 2025
@FabijanC FabijanC merged commit 14ab386 into main Jan 17, 2025
1 check passed
@FabijanC FabijanC deleted the early-exit-test branch January 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Related to code testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants