Misc FAKE fixes #1783
Open
Misc FAKE fixes #1783
+243
−308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensldm
added
Clean up
Needs-second-approval
hensldm
commented
Jan 7, 2025
| @@ -1687,9 +1687,8 @@ PlayerExplosive Player_GetExplosiveHeld(Player* player) { | |||
| PlayerSword Player_SwordFromIA(Player* player, PlayerItemAction itemAction) { | |||
| PlayerSword sword = PLAYER_SWORD_KOKIRI; | |||
|
|
|||
| //! FAKE: | |||
| if ((itemAction == PLAYER_IA_LAST_USED) || | |||
There was a problem hiding this comment.
Note I just removed the fake label here as I actually don't think this is a fake.
| //! FAKE: | ||
| // https://decomp.me/scratch/JrEnl | ||
| Matrix_MultVec3f(&(init->elements + i)->dim.vtx[j], &sp54[j]); | ||
| Matrix_MultVec3f(init->elements[i].dim.vtx + j, &sp54[j]); |
There was a problem hiding this comment.
Looks better (though might still be considered a fake). Note this matches what was already in func_809CE068 in BgSpdweb
| //! FAKE: | ||
| csId = CutsceneManager_GetAdditionalCsId(this->csIdList[i] = csId); | ||
| // clang-format off | ||
| this->csIdList[i] = csId; \ |
There was a problem hiding this comment.
Perhaps still a fake, but I prefer this over what it was. Possibly a macro of some kind?
AngheloAlf
reviewed
Jan 7, 2025
AngheloAlf
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried going through and fixing things marked as
FAKE.Note there are some that I couldn't fully fix, but was able to find a way to match with an
if (1)instead. In those cases I did change them to imo the better fake match.