Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsdiff enhancements to diff against a reference dump #260

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

fsdiff enhancements to diff against a reference dump #260

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a4071e
xcpng-fs-diff: remove no-op statement looking like a decorator
ydirson Sep 11, 2024
5aa7463
WIP xcpng-fs-diff: use lib.commands.ssh and activate logging
ydirson Sep 11, 2024
b531c66
xcpng-fs-diff: avoid non-standard "exit(-1)"
ydirson Sep 11, 2024
9801f30
xcpng-fs-diff: change prints to logs
ydirson Sep 11, 2024
850960d
xcpng-fs-diff: new test to check against reference files
ydirson Sep 11, 2024
e76d4ba
xcpng-fs-diff: ignore /etc/xapi.d/plugins/vmssc
ydirson Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/host.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,3 +566,8 @@ def enable_hsts_header(self):
def disable_hsts_header(self):
self.ssh(['rm', '-f', f'{XAPI_CONF_DIR}/00-XCP-ng-tests-enable-hsts-header.conf'])
self.restart_toolstack(verify=True)

def firmware_type(self):
retcode = self.ssh(['test', '-d', '/sys/firmware/efi/'],
check=False, simple_output=False).returncode
return "uefi" if retcode == 0 else "bios"
Comment on lines +570 to +573
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the VM object, there's is_uefi(). Would it make sense to be consistent with it?

Loading