fsdiff enhancements to diff against a reference dump #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not meant to be a fixture anyway. Signed-off-by: Yann Dirson <[email protected]>
This suppresses hostkey checking, making the script more suitable for non-interactive use, and makes it easier to understand when something goes wrong. FIXME locate "lib" more properly Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
Tests for generation of the reference files, and for checking against them. Signed-off-by: Yann Dirson <[email protected]>
byte-compiled version of /etc/xapi.d/plugins/vmss Signed-off-by: Yann Dirson <[email protected]>
stormi
reviewed
Oct 11, 2024
| @@ -5,7 +5,6 @@ | |||
| # Requirements: | |||
| # - 2 XCP-ng host of same version | |||
|
|
|||
| pytest.fixture(scope='module') | |||
stormi
reviewed
Oct 11, 2024
Comment on lines
+570
to
+573
| def firmware_type(self): | ||
| retcode = self.ssh(['test', '-d', '/sys/firmware/efi/'], | ||
| check=False, simple_output=False).returncode | ||
| return "uefi" if retcode == 0 else "bios" |
There was a problem hiding this comment.
In the VM object, there's is_uefi(). Would it make sense to be consistent with it?
stormi
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Reference files will keep evolving when we test nightly builds, so does it make sense to store them here? How about we give the test a location where it can download them from if they exist, that we would populate after each nightly build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.