-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gui taproot #986
Gui taproot #986
Conversation
If not too complicated i think it's worth hiding the network and Taproot selectors under a collapsible "Advanced settings" options at the bottom right before the buttons. As @kloaec rightly points out 99% people want mainnet, not signet or regtest, and the 1% can use advanced settings. Same goes for Taproot for now. |
Tried to put the pick_list behind an 'advanced settings' that would open a modal, but iced does not support the nesting of overlay iced-rs/iced#940 |
205c0a4
to
1aca594
Compare
1aca594
to
28fcb43
Compare
I can't click on next anymore after removing the Bitbox from the path though. |
for the new implem of PartialOrd for async_hwi::DeviceKind
28fcb43
to
b7f35c0
Compare
When manually selecting coins, i can't click on "Next" when creating a spend. |
I don't think the bug above is related to this PR. I also found #1024 which i don't think is related to this PR. |
tACK b7f35c0 -- i've lightly tested this a couple times. It's good enough to get in and get tested along with the other changes. |
a7f2bcc gui: handle daemon stop error (edouardparis) 924df8e bump liana:master (edouardparis) Pull request description: based on #986 ACKs for top commit: darosior: ACK a7f2bcc Tree-SHA512: 24c48948f10eed7f04dcab0779b75d89c5fd40441c04dffb6f4e5b3e682ca2ca36de51cdc69e7679ed262c4e92691d789c29822972f5c99290c54d13c7dc3472
based on #985