Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taproot support #55

Closed
darosior opened this issue Oct 7, 2022 · 6 comments
Closed

Taproot support #55

darosior opened this issue Oct 7, 2022 · 6 comments
Assignees
@darosior

Comments

@darosior
Copy link
Member

darosior commented Oct 7, 2022

As Miniscript for Tapscript isn't formally specified yet, we are going to start without Taproot support. We need to have Taproot support as soon as possible, and for this i need to make progress on the C++ implementation of Tap-Miniscript.

Hopefully we'll have it in Bitcoin Core 25.0, in approximately 6 months from now. Alternately, maybe we can carve out something similar to what we used to do in revaultd before we had Miniscript support in bitcoind (watch by address)... But that's ugly 😭
@darosior darosior self-assigned this Oct 7, 2022
@darosior darosior mentioned this issue Oct 8, 2022
Open
@darosior
Copy link
Member Author

MiniTapscript is now specified sipa/miniscript#134 and there is a PR implementing it into Bitcoin Core bitcoin/bitcoin#27255.

@darosior
Copy link
Member Author

darosior commented Oct 8, 2023

Tapscript support for Miniscript got merged in Bitcoin Core and will be available from 26.

@darosior
Copy link
Member Author

I think it would be good to implement it for the daemon first (let's say in v4?) before enabling it on the GUI once (some) signers support it.

@bigspider
Copy link

:)

@darosior
Copy link
Member Author

Bitcoin Core 26.0 was now released, this should become a priority.

@darosior darosior moved this to Todo in Liana v5 Dec 11, 2023
@darosior darosior moved this from Todo to Done in Liana v5 Mar 8, 2024
@darosior
Copy link
Member Author

This was implemented in #985 and #986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darosior darosior

Labels
None yet
Projects
No open projects
Liana v5
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bigspider @darosior