gui(installer): allow deletion of any primary key and prevent deletion of all recovery paths #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pass the number of recovery paths as a separate parameter in order not to consume the iterator, but perhaps this could be done differently, e.g. collecting the iterator items into a Vec. |
jp1ac4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #1411 and #1407, which relate to whether primary or recovery keys, respectively, can be deleted in the installer.
It lets a user delete any primary key as long as there are two or more.
It lets a user delete a key from a recovery path only if there are at least two recovery paths or at least two keys in the given recovery path.