Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not let the user eliminate a recovery path if it's the only one #1407

Closed
nondiremanuel opened this issue Oct 31, 2024 · 1 comment
Closed

Do not let the user eliminate a recovery path if it's the only one #1407

nondiremanuel opened this issue Oct 31, 2024 · 1 comment
Assignees
@jp1ac4
Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related Nice to have If it's not completed in time for the current version, it can be postponed
Milestone
v10 Liana - UI fi...

Comments

@nondiremanuel
Copy link
Collaborator

Currently with Liana it is not possible to create a descriptor without recovery paths. It can be then confusing for the user to have the possibility of deleting all the recovery paths in the custom setup flow.

image

Right now we manage the situation by not letting the user click on "Continue", but this is not optimal. We should prevent the user from going into a situation in which there is no recovery path in the first place since we don't support it.

This is currently applicable only to the custom setup since in the templates we don't allow the user adding or removing keys/paths.
@nondiremanuel nondiremanuel added GUI gui related Glitch A small annoyance in the GUI that is not entirely a bug Nice to have If it's not completed in time for the current version, it can be postponed labels Oct 31, 2024
@nondiremanuel nondiremanuel moved this to Todo in Liana General Oct 31, 2024
@pythcoiner pythcoiner mentioned this issue Nov 5, 2024
Closed
@jp1ac4 jp1ac4 self-assigned this Feb 10, 2025
@jp1ac4 jp1ac4 moved this from Todo to In Progress in Liana General Feb 10, 2025
@jp1ac4 jp1ac4 mentioned this issue Feb 10, 2025
Merged
@jp1ac4 jp1ac4 moved this from In Progress to In Review in Liana General Feb 10, 2025
edouardparis added a commit that referenced this issue Feb 10, 2025
@edouardparis
Merge #1566: gui(installer): allow deletion of any primary key and pr…
4dc10d1 
…event deletion of all recovery paths

99ba17d gui(installer): allow deletion of any prim key if more than one (Michael Mallan)
ca3bd63 gui(installer): prevent deletion of all recovery paths (Michael Mallan)

Pull request description:

  This is to fix #1411 and #1407, which relate to whether primary or recovery keys, respectively, can be deleted in the installer.

  It lets a user delete any primary key as long as there are two or more.

  It lets a user delete a key from a recovery path only if there are at least two recovery paths or at least two keys in the given recovery path.

ACKs for top commit:
  edouardparis:
    ACK 99ba17d

Tree-SHA512: 3838c29d92b1f0f5bd60cee303771e98434382c4fcf2a38a013b86a66cd9943dc299129534530469a0cb7c3eb62929b4fedb346e40d90fb3fd18b27c4c376fb4
@nondiremanuel nondiremanuel moved this from In Review to Done in Liana General Feb 10, 2025
@nondiremanuel
Copy link
Collaborator Author

Closed by #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jp1ac4 jp1ac4

Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related Nice to have If it's not completed in time for the current version, it can be postponed
Projects
Liana General
Status: Done
Milestone
v10 Liana - UI fixes and other activi...
Development

No branches or pull requests
2 participants
@nondiremanuel @jp1ac4