-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support asset module #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
2 tasks
SoonIter
changed the title
feat: support asset
feat: support asset by Jan 15, 2025
generator['asset'].experimentalLibPreserveImport
Timeless0911
changed the title
feat: support asset by
feat: support asset module
Jan 15, 2025
generator['asset'].experimentalLibPreserveImport
SoonIter
force-pushed
the
asset-support-rust
branch
2 times, most recently
from
January 16, 2025 15:52
cafaf00
to
1682dac
Compare
Merged
2 tasks
SoonIter
force-pushed
the
asset-support-rust
branch
2 times, most recently
from
January 20, 2025 11:30
fb2d90d
to
8237684
Compare
SoonIter
force-pushed
the
asset-support-rust
branch
from
January 22, 2025 10:03
8237684
to
6968aae
Compare
Timeless0911
approved these changes
Jan 23, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
there are some cases to show the rslib asset/module artifect after this change
1. asset/resource
input
└── src ├── assets │ └── logo.svg // <-- └── index.tsx
output
2. asset/inline
decided by
output.dataUriLimit
input
└── src ├── assets │ └── logo.svg // <-- └── index.tsx
output
3. asset/source
input
└── src ├── assets │ └── logo.svg // <-- └── index.tsx
output
4. svgr
queryImport is only supported in bundle, not supported in bundleless
we recommend that bundleless uses
mixedImport
input
└── src ├── assets │ └── logo.svg // <-- └── index.tsx
output
./dist └── esm ├── assets │ └── logo.mjs // <-- both url and Svgr ReactComponent ├── index.d.ts └── index.mjs
5. publicPath
you can switch to old behavior (contain
__webpack_require__.p
) by setoutput.assetPrefix
default value of
output.assetPrefix
is"auto"
Related Links
close #570
associated with https://github.com/web-infra-dev/rspack/pull/8724/files#
close #219
close #230
close #231
Checklist