Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): output.assetsInclude adds a rule but not exposes public api #4385

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Jan 17, 2025

Summary

not regular

image image

should be ${type}-asset-url

font  font-asset-url
additional-assets  additional-assets-asset-url

Related Links

for Rslib Asset
web-infra-dev/rslib#684

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1ca85be
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/678de601cb8c390008f00085
😎 Deploy Preview https://deploy-preview-4385--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title fix(core): output.assetsInclude add a rule but not export public api fix(core): output.assetsInclude adds a rule but not exposes public api Jan 17, 2025
@SoonIter SoonIter requested a review from chenjiahan January 17, 2025 09:18
@SoonIter SoonIter requested a review from chenjiahan January 20, 2025 04:01
@SoonIter SoonIter requested a review from chenjiahan January 20, 2025 06:13
@SoonIter SoonIter enabled auto-merge (squash) January 20, 2025 06:57
@SoonIter SoonIter merged commit 4f9650e into main Jan 20, 2025
9 checks passed
@SoonIter SoonIter deleted the fix-export-additional-api branch January 20, 2025 08:11
@chenjiahan chenjiahan mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants