fix[ux]: catch state modifying functions in range expr and loop iterator

tests/functional/syntax/test_for_range.py

@@ -3,7 +3,13 @@
 import pytest
 
 from vyper import compiler
-from vyper.exceptions import ArgumentException, StructureException, TypeMismatch, UnknownType
+from vyper.exceptions import (
+    ArgumentException,
+    StateAccessViolation,
+    StructureException,
+    TypeMismatch,
+    UnknownType,
+)
 
 fail_list = [
     (
@@ -322,6 +328,36 @@ def foo():
         None,
         "10.1",
     ),
+    (
+        """
+interface I:
+    def bar() -> uint256: payable
+
+@external
+def bar(t: address):
+    for i: uint256 in range(extcall I(t).bar(), bound=10):
+        pass
+    """,
+        StateAccessViolation,
+        "May not call state modifying function within a range expression.",
+        None,
+        "extcall I(t).bar()",
+    ),
+    (
+        """
+interface I:
+    def bar() -> uint256: payable
+
+@external
+def bar(t: address):
+    for i: uint256 in range(1, extcall I(t).bar(), bound=10):
+        pass
+    """,
+        StateAccessViolation,
+        "May not call state modifying function within a range expression.",
+        None,
+        "extcall I(t).bar()",
+    ),
 ]
 
 for_code_regex = re.compile(r"for .+ in (.*):", re.DOTALL)

vyper/semantics/analysis/local.py

@@ -935,6 +935,11 @@ def _validate_range_call(node: vy_ast.Call):
     start, end = (vy_ast.Int(value=0), node.args[0]) if len(node.args) == 1 else node.args
     start, end = [i.get_folded_value() if i.has_folded_value else i for i in (start, end)]
 
+    if any(isinstance((extcall := n), vy_ast.ExtCall) for n in (start, end)):
+        raise StateAccessViolation(
+            "May not call state modifying function within a range expression.", extcall
+        )
+
     if "bound" in kwargs:
         bound = kwargs["bound"]
         if bound.has_folded_value: