fix[ux]: catch state modifying functions in range expr and loop iterator

[tserg]

What I did

Fix #3172, #3504, #3867. Closes #3188.

How I did it

Check for modifying member and contract functions in a range call and as loop iterator.

How to verify it

See tests.

Commit message

fix[ux]: catch state modifying functions in range expr and loop iterator

This commit catches state-modifying functions in the iterator and range
expression of a for loop, and throws a StateAccessViolation exception.

Description for the changelog

Cute Animal Picture

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (dd5a3d9) to head (fc76404).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3884      +/-   ##
==========================================
- Coverage   92.06%   92.06%   -0.01%     
==========================================
  Files         120      120              
  Lines       17335    17352      +17     
  Branches     2935     2940       +5     
==========================================
+ Hits        15960    15975      +15     
- Misses        957      958       +1     
- Partials      418      419       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-cooper]

interesting that we don't need (as much) analysis anymore. but i'm not sure this works for side effecting expressions which aren't marked with extcall (e.g. raw_call, internal calls which result in state changes, etc). i think a more robust solution is going to be to pass around a context variable with the current scope's modifiability information

[charles-cooper]

this is a dup of #3546 no?

[cyberthirst]

interface I:
    def bar() -> DynArray[uint256, 10]: nonpayable

@external
def bar(t: address):
    for i: uint256 in extcall I(t).bar():
        pass

vyper.exceptions.CodegenPanic: unhandled exception typechecker missed this, parse_ExtCall

  contract "tests/custom/test4.vy:6", function "bar", line 6:22 
       5 def bar(t: address):
  ---> 6     for i: uint256 in extcall I(t).bar():
  -----------------------------^
       7         pass


This is an unhandled internal compiler error. Please create an issue on Github to notify the developers!
https://github.com/vyperlang/vyper/issues/new?template=bug.md

[tserg]

I added a test for raw call because it has its own analysis in its build_IR function. Can I move these syntax tests to tests/functional/syntax/test_raw_call.py?

[charles-cooper]

yea

[tserg]

done!