Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compile-time evaluation of slice() #3667

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

add compile-time evaluation of slice() #3667

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
71d3618
add slice evaluate() and tests
iFrostizz Nov 10, 2023
42188f6
add comp/run time equivalence check
iFrostizz Nov 10, 2023
3614409
lint
iFrostizz Nov 10, 2023
a68d783
add compile-time strict type check
iFrostizz Nov 10, 2023
a782cbe
add fuzz tests, harden Slice
iFrostizz Nov 10, 2023
b3ad481
revert unit tests
iFrostizz Nov 10, 2023
162d6b3
add more robust fuzzing, better slice errors
iFrostizz Nov 10, 2023
7c011ea
remove bytes conversion
iFrostizz Nov 10, 2023
ea35be9
fix slice bound for dynamic types
iFrostizz Nov 11, 2023
1dd6af5
add dynamic bounds check
iFrostizz Nov 11, 2023
16cac7d
rename variables and use a tuple
iFrostizz Nov 25, 2023
5faddf8
better naming, use hypothesis bytes
iFrostizz Dec 9, 2023
261fb62
lint
iFrostizz Dec 9, 2023
4ea5d0e
use `zfill`
iFrostizz Dec 10, 2023
e585b77
reduce nesting, better variables
iFrostizz Dec 20, 2023
5b959fe
lint
iFrostizz Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions vyper/builtins/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,20 +296,25 @@ class Slice(BuiltinFunction):

def evaluate(self, node):
(lit, st, le) = node.args[:3]
(st_val, le_val) = (st.value, le.value)
if isinstance(lit, vy_ast.Bytes):
sublit = lit.value[st_val : (st_val + le_val)]
return vy_ast.Bytes.from_node(node, value=sublit)
elif isinstance(lit, vy_ast.Str):
sublit = lit.value[st_val : (st_val + le_val)]
return vy_ast.Str.from_node(node, value=sublit)
elif isinstance(lit, vy_ast.Hex):
length = len(lit.value) // 2 - 1
if length != 32:
# TODO unreachable?
raise UnfoldableNode
sublit = lit.value[st_val : (2 + st_val + (le_val * 2))]
return vy_ast.Bytes.from_node(node, value=sublit)
if (
isinstance(lit, (vy_ast.Bytes, vy_ast.Str, vy_ast.Hex))
and isinstance(st, vy_ast.Int)
and isinstance(le, vy_ast.Int)
):
(st_val, le_val) = (st.value, le.value)
if isinstance(lit, vy_ast.Bytes):
sublit = lit.value[st_val : (st_val + le_val)]
return vy_ast.Bytes.from_node(node, value=sublit)
elif isinstance(lit, vy_ast.Str):
sublit = lit.value[st_val : (st_val + le_val)]
return vy_ast.Str.from_node(node, value=sublit)
else:
length = len(lit.value) // 2 - 1
if length != 32:
# TODO unreachable?
raise UnfoldableNode
sublit = lit.value[st_val : (2 + st_val + (le_val * 2))]
return vy_ast.Bytes.from_node(node, value=sublit)
else:
raise UnfoldableNode

Expand Down