add compile-time evaluation of slice()
#3667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3667 +/- ##
==========================================
- Coverage 89.61% 83.68% -5.93%
==========================================
Files 80 92 +12
Lines 11343 13077 +1734
Branches 2553 2940 +387
==========================================
+ Hits 10165 10944 +779
- Misses 791 1695 +904
- Partials 387 438 +51 ☔ View full report in Codecov by Sentry. |
vyper/builtins/functions.py
Outdated
| if isinstance(literal_value, vy_ast.Bytes): | ||
| sublit = literal_value.value[start_val : (start_val + length_val)] | ||
| return vy_ast.Bytes.from_node(node, value=sublit) | ||
| elif isinstance(literal_value, vy_ast.Str): |
There was a problem hiding this comment.
no need for elif because the previous branch already returned
There was a problem hiding this comment.
so put "if" everywhere right ? it was lookin safer
iFrostizz
commented
Dec 20, 2023
| if len(bytes_value) != 32: | ||
| raise ArgumentException("Length can only be of 32", bytestring) | ||
| elif isinstance(bytestring, vy_ast.Str): | ||
| bytes_value = bytestring.value |
There was a problem hiding this comment.
@charles-cooper how do you feel about this line ? Here the bytes_value type is str while otherwise it's bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adding compile-time evaluation support for
slice.How I did it
Fill in the blanks in the
evaluatefunction of theSliceclass builtinHow to verify it
Wrote some unit tests that compare the compile time and runtime evaluation of the function for equivalent inputs and made sure that the output were the same.
Commit message
Add compile-time support for the
slicebuilt-inDescription for the changelog
Cute Animal Picture