fix: guard against pop in iter for range
#3188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.02%
==========================================
Files 88 88
Lines 11044 11048 +4
Branches 2337 2338 +1
==========================================
+ Hits 9761 9767 +6
+ Misses 826 825 -1
+ Partials 457 456 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fubuloubu
approved these changes
Dec 10, 2022
vyper/codegen/expr.py
Outdated
| @@ -670,6 +671,12 @@ def parse_Call(self): | |||
| darray = Expr(self.expr.func.value, self.context).ir_node | |||
| assert len(self.expr.args) == 0 | |||
| assert isinstance(darray.typ, DArrayType) | |||
|
|
|||
| if self.context.is_constant(): | |||
There was a problem hiding this comment.
i don't think this is the right place to do this
charles-cooper
requested changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3172.
How I did it
Pass context to
pop_dyn_arrayand check constancy.How to verify it
See tests
Commit message
Description for the changelog
Guard against
popin iterforrangeCute Animal Picture