Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose renaming observation type from finding -> implementation-issue #2105

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Propose renaming observation type from finding -> implementation-issue #2105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8093b
Adjust observation type in enumeration from #2104
aj-stein-gsa Feb 13, 2025
dff1aac
Adjust values to doc and impl-issue for #2104
aj-stein-gsa Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/metaschema/oscal_assessment-common_metaschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,10 +898,12 @@
<group-as name="types" in-json="ARRAY"/>
<constraint>
<allowed-values id="oscal-observation-values" target="." allow-other="yes">
<enum value="ssp-statement-issue">A difference between the SSP implementation statement, and actual implementation.</enum>
<enum value="ssp-statement-issue" deprecated="1.1.4">**(deprecated)** Use 'documentation-finding' instead.</enum>
<enum value="control-objective">An observation about the status of a the associated control objective.</enum>
<enum value="mitigation">A mitigating factor was identified.</enum>
<enum value="finding">An assessment finding. Used for observations made by tools, penetration testing, and other means.</enum>
<enum value="finding" deprecated="1.1.4">**(deprecated)** Use 'implementation-finding' instead.</enum>
<enum value="documentation-issue">An observation of possible risk from a difference between the documentation for a system and its implementation.</enum>
<enum value="implementation-issue">An observation of possible risk from the system's implementation from security scanning tools, penetration testing, and other means.</enum>
<enum value="historic">An observation from a past assessment, which was converted to OSCAL at a later date.</enum>
</allowed-values>
</constraint>
Expand Down