Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose renaming observation type from finding -> implementation-issue #2105

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aj-stein-gsa
Copy link
Contributor

Committer Notes

If accepted, closes #2104.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • ~Have you written new tests for your core changes, as applicable?
  • ~Have you included examples of how to use your new feature(s)?
  • Have you updated the OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the OSCAL-Pages and OSCAL_Reference repositories. Documentation will update once PR merged and documentation pipeline initiated.

@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner February 13, 2025 15:07
Act on feedback from community member @egyptiankarim in the issue for more descriptive and constructive enum values.

Source: usnistgov#2104 (comment)
@aj-stein-gsa aj-stein-gsa changed the title Propose renaming observation type from finding -> tool-finding Propose renaming observation type from finding -> implementation-issue Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant