-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU project chipyard changes #2190
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for run-binaries-debug-bg
? It just runs them in the background? Can't you just do make run-binaries .... &
to do that?
Also, what is the change to riscv-tools-feedstock
for?
generators/chipyard/src/main/scala/config/RadianceConfigs.scala
Outdated
Show resolved
Hide resolved
generators/chipyard/src/main/scala/config/CoalescerConfigs.scala
Outdated
Show resolved
Hide resolved
@hansungk's changes
Didn't mean to change that, will revert |
run-binaries-debug-bg makes sure the compile stage before sim is serialized. Was mostly for personal use though, we can leave it out |
Hmm, the Makefile dependencies should already be enforcing compile ahead of sim... unless there's something which the Makefile isn't aware of that is a dependency. |
Yep, it's just that if you kick off many run-binaries-debug &, they might compile the same thing concurrently and might mangle some states. was mostly used for same config but different binary launches |
@@ -233,6 +237,8 @@ $(TOP_SMEMS_CONF) $(MODEL_SMEMS_CONF) &: $(MFC_SMEMS_CONF) $(MFC_MODEL_HRCHY_JS | |||
--model-module-name $(MODEL) \ | |||
--out-dut-smems-conf $(TOP_SMEMS_CONF) \ | |||
--out-model-smems-conf $(MODEL_SMEMS_CONF) | |||
# for blackboxed SRAMs: define mem here and use generated module name in blackbox source | |||
-[ -f $(base_dir)/vlsi/add.mem.conf ] && cat $(base_dir)/vlsi/add.mems.conf >> $(TOP_SMEMS_CONF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a cleaner way to do this. What if you have the generator emit a supplementary file .custom.mems.conf
via addResource
in rocket-chip? Then in this make job, concatenate that file into TOP_SMEMS_CONF
if it exists.
I don't like having this magic file in the vlsi/ directory.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI