feat: plugins can describe their own event listeneners

[gentlementlegen]

Resolves #73
Depends on #71

[gentlementlegen]

For this PR to work properly, all the related manifest pull-requests have to be merged, @0x4007 let me know if I am good to merge them.

[0x4007]

@gentlementlegen yes merge them.

[rndquu]

@gentlementlegen Check this config.

Trying to run the hello world plugin and the kernel responds with No handler found for event issue_comment although the config does have the runsOn section.

What am I doing wrong?

[gentlementlegen]

@gentlementlegen Check this config.

Trying to run the hello world plugin and the kernel responds with No handler found for event issue_comment although the config does have the runsOn section.

What am I doing wrong?

I updated the README with a proper config due to the new schema. I think the runsOn is misused in yours, it should go within the plugin itself.

[rndquu]

@gentlementlegen Check this issue, this config (from readme) and this comment. It seems that the "hello-world" plugin responds to any comment while the expected behavior is to respond only to the /hello command.

[gentlementlegen]

@rndquu The issue was that the hello-world plugin would not serve the manifest, so the kernel would not be able to filter out the commands. I added a manifest and serve it, which should solve the problem. Also I merged in PR #75 within this one because it was needed to properly filter out the commands anyway.

[rndquu]

@rndquu The issue was that the hello-world plugin would not serve the manifest, so the kernel would not be able to filter out the commands. I added a manifest and serve it, which should solve the problem. Also I merged in PR #75 within this one because it was needed to properly filter out the commands anyway.

If plugin doesn't serve manifest at all then what's going to happen? Perhaps we should create a new github issue for showing empty manifest related error and stopping plugin execution?

[rndquu]

Works fine

[gentlementlegen]

@rndquu Thank you for the remark, created a ticket for it: #78