Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip plugin run on missing manifest.json file #78

Closed
gentlementlegen opened this issue Jul 24, 2024 · 4 comments
Closed

Skip plugin run on missing manifest.json file #78

gentlementlegen opened this issue Jul 24, 2024 · 4 comments

Comments

@gentlementlegen
Copy link
Member

The kernel should skip plugins that do not serve a manifest as they should be considered invalid.

          > @rndquu The issue was that the `hello-world` plugin would not serve the manifest, so the kernel would not be able to filter out the commands. I added a manifest and serve it, which should solve the problem. Also I merged in PR #75 within this one because it was needed to properly filter out the commands anyway.

If plugin doesn't serve manifest at all then what's going to happen? Perhaps we should create a new github issue for showing empty manifest related error and stopping plugin execution?

Originally posted by @rndquu in #74 (comment)

Copy link

ubiquibot bot commented Jul 24, 2024

@gentlementlegen, You are not allowed to add Time: <1 Hour

Copy link

ubiquibot bot commented Jul 24, 2024

! No permission to set labels

@gentlementlegen
Copy link
Member Author

I think this is covered by #80 and now when a manifest is not found, no run happens because the manifest should describe which events the plugin will react to.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Copy link
Contributor

ubiquity-os bot commented Sep 24, 2024

# Issue was not closed as completed. Skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant