Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support AggregateError #69

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

feat: support AggregateError #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
429841a
feat: support AggregateError
whilefoo Feb 13, 2025
8aca137
fix: refactor into function
whilefoo Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,19 @@ export async function createActionsPlugin<TConfig = unknown, TEnv = unknown, TCo
} catch (error) {
console.error(error);

let loggerError: LogReturn | null;
if (error instanceof Error) {
core.setFailed(error);
loggerError = context.logger.error(`Error: ${error}`, { error: error });
} else if (error instanceof LogReturn) {
core.setFailed(error.logMessage.raw);
let loggerError: LogReturn | Error;
whilefoo marked this conversation as resolved.
Show resolved Hide resolved
if (error instanceof AggregateError) {
loggerError = context.logger.error(error.errors.map((err) => (err instanceof Error ? err.message : err)).join("\n\n"), { error });
} else if (error instanceof Error || error instanceof LogReturn) {
loggerError = error;
} else {
core.setFailed(`Error: ${error}`);
loggerError = context.logger.error(`Error: ${error}`);
loggerError = context.logger.error(String(error));
}

if (loggerError instanceof LogReturn) {
core.setFailed(loggerError.logMessage.diff);
} else if (loggerError instanceof Error) {
core.setFailed(loggerError);
}

if (pluginOptions.postCommentOnError && loggerError) {
Expand Down
8 changes: 5 additions & 3 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,13 @@ export function createPlugin<TConfig = unknown, TEnv = unknown, TCommand = unkno
} catch (error) {
console.error(error);

let loggerError: LogReturn | Error | null;
if (error instanceof Error || error instanceof LogReturn) {
let loggerError: LogReturn | Error;
if (error instanceof AggregateError) {
loggerError = context.logger.error(error.errors.map((err) => (err instanceof Error ? err.message : err)).join("\n\n"), { error });
} else if (error instanceof Error || error instanceof LogReturn) {
loggerError = error;
} else {
loggerError = context.logger.error(`Error: ${error}`);
loggerError = context.logger.error(String(error));
}

if (pluginOptions.postCommentOnError && loggerError) {
Expand Down