feat: support AggregateError #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| loggerError = context.logger.error(`Error: ${error}`, { error: error }); | ||
| } else if (error instanceof LogReturn) { | ||
| core.setFailed(error.logMessage.raw); | ||
| let loggerError: LogReturn | Error; |
There was a problem hiding this comment.
Wouldn't it be worth to wrap this in a function? It seems that it is the same logic for actions and workers, would avoid duplicate code and mistakes
|
The problem with aggregate error is that it accepts pretty much anything, so if you push an array of logger errors then it looks like this: Meniole/plugin-template#1 (comment) Corresponding code: throw new AggregateError([new Error("error 1"), new Error("error 2"), logger.error("logger error"), new RangeError("range error")]);But I think it would be the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #64
QA: ubiquibot-whilefoo-testing/testing#19 (comment)