Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: table of contents #394

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

jacobhq
Copy link
Contributor

@jacobhq jacobhq commented Jan 21, 2025

Context & Description

Fixes #343

  • Avoid layout shift
  • Shorten headings
  • Generate heading IDs that don't include [Object object] when using headings with code in them

Device Screenshots

Mobile localhost_3000_(iPhone XR)
Desktop localhost_3000_

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 21, 2025
@jacobhq jacobhq marked this pull request as ready for review January 22, 2025 12:03
@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 22, 2025

  • Avoid layout shift
  • Shorten headings

@Valerioageno
Copy link
Member

Hey @jacobhq, thanks for it!

  1. Can you add a screenshot?
  2. We should try to deliver the full feature on the first try since it doesn't make much sense to deliver a buggy experience. Could you please also address the two remaining tasks you defined before the review?

@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 22, 2025

As you can see in the desktop screenshot, the long headings look quite ugly. Maybe I should not include lower heading levels in the index?

There is also issues when there are headings with the same id (same content), for example https://tuono.dev/documentation/installation#installation. Should I just manually change those docs pages?

@jacobhq jacobhq marked this pull request as draft January 22, 2025 15:44
@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 22, 2025

Working example

2025-01-22-17-16-40.mp4

Problems with heading IDs

2025-01-22-17-17-37.mp4

I will write a thing to generate heading IDs later this evening, then the PR will be ready.

@jacobhq jacobhq marked this pull request as ready for review January 22, 2025 19:44
@Valerioageno
Copy link
Member

Hey! Thanks for this.
I'm locally test it! I'll let you know next days!

@Valerioageno
Copy link
Member

I found a couple of bugs! Do you mind if I add a commit with some UI improvement, and then we address the bugs?

@jacobhq
Copy link
Contributor Author

jacobhq commented Jan 23, 2025

Yeah sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Refactor for easier readability
2 participants