Pin Java version as 23.0.1 #24786
Closed
Pin Java version as 23.0.1 #24786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/java-23.0.1
branch
from
0737f1c to
b230e8f
Compare
|
I don’t think that’s the right approach. We should fix the tests, instead. |
ebyhr
force-pushed
the
ebi/java-23.0.1
branch
from
b230e8f to
1a03f38
Compare
|
Right, we should find a new timezone. This is a workaround until finding such timezone. |
|
Which tests are failing? We should also consider writing tests that are not sensitive to specific timezone rules. They used to be needed for the old timestamp semantics, but I don't think that's the case anymore. |
|
23 jobs (mostly type mapping tests in connectors) are failing: https://github.com/trinodb/trino/actions/runs/12941902891/job/36098727148 |
wendigo
approved these changes
Jan 24, 2025
23.0.2 upgraded IANA Time Zone Database to 2024b. It changed a gap in America/Bahia_Banderas.
ebyhr
force-pushed
the
ebi/java-23.0.1
branch
from
1a03f38 to
e6ae54c
Compare
|
@ebyhr no such timezone exists anymore that has gap in 1970-01-01 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
23.0.2 upgraded IANA Time Zone Database to 2024b.
It changed a gap in America/Bahia_Banderas.
openjdk/jdk23u@73b2341
We changed the timezone from
Asia/Katmanduin prestodb/presto#10128.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.