Update Java to 23.0.2 #24787
Merged
Update Java to 23.0.2 #24787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/23.0.2
branch
2 times, most recently
from
ae171c6 to
e4828b0
Compare
wendigo
force-pushed
the
serafin/23.0.2
branch
from
e4828b0 to
6e892b0
Compare
wendigo
force-pushed
the
serafin/23.0.2
branch
8 times, most recently
from
7c28499 to
03593e8
Compare
|
Alternative approach to #24786 |
|
Remaining failures are snowflake related. Some test cases were removed, one test was disabled (delta lake), maybe it's no longer needed. Cc @ebyhr |
wendigo
force-pushed
the
serafin/23.0.2
branch
from
03593e8 to
59e1674
Compare
electrum
approved these changes
Jan 26, 2025
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeReadTimestamps.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/23.0.2
branch
from
2761497 to
5168d64
Compare
|
|
This brings updated timezonedb to version 2024b (openjdk/jdk23u@73b2341) which amends historical timezone definitions for Mexico/Bahia_Banderas that we use for testing timezone gap around the unix timestamp epoch. Corresponding Joda time update also has these timezone definitions updated. PostgreSQL test server was upgraded to 12 to correctly handle UTC around epoch. MySQL was updated to 8.0.41 due to the same reason. Temporary downgrade JDK for ppc64 to make CI happy
wendigo
force-pushed
the
serafin/23.0.2
branch
from
5168d64 to
fb1d2e0
Compare
hashhar
reviewed
Jan 29, 2025
| @@ -106,6 +107,7 @@ public void registerTables() | |||
| } | |||
|
|
|||
| @Test | |||
| @Disabled("This test assumes specific tzdb version and it will fail on mismatch between Spark and Trino tzdb versions") | |||
There was a problem hiding this comment.
isn't this a user-facing issue then?
There was a problem hiding this comment.
What if we update the JDK used to run Spark to the latest patch release for that version?
hashhar
reviewed
Jan 29, 2025
| @@ -601,7 +601,6 @@ public void testTimestampWithTimeZoneFromTrinoDefaultTimeZone() | |||
| @Test | |||
| public void testUnsupportedTimestampWithTimeZoneValues() | |||
| { | |||
| // The range for TIMESTAMP values is '1970-01-01 00:00:01.000000' to '2038-01-19 03:14:07.499999' | |||
There was a problem hiding this comment.
the comment is still correct, restoring this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings updated timezonedb to version 2024b
(openjdk/jdk23u@73b2341) which amends historical timezone definitions for Mexico/Bahia_Banderas that we use for testing timezone gap around the unix timestamp epoch.
Corresponding Joda time update also has these timezone definitions updated. PostgreSQL test server was upgraded to 12 to correctly handle
UTC around epoch. MySQL was updated to 8.0.41 due to the same reason.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: