Fix: JavaScript Editor Help Button Color and Click Functionality Issues #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterbender please review this |
|
Please use the same indentation and use of spaces as the rest of the code. |
|
@walterbender made changes as recommended. |
js/widgets/jseditor.js
Outdated
| @@ -377,6 +377,12 @@ class JSEditor { | |||
| this._code = JSGenerate.code; | |||
| this._jar.updateCode(this._code); | |||
| this._setLinesCount(this._code); | |||
| const helpBtn = docById("js_editor_help_btn"); | |||
| if(helpBtn) { | |||
There was a problem hiding this comment.
space before the ( please.
There was a problem hiding this comment.
@walterbender made changes as recommended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #3573 malfunctioning behavior of the help button in the JavaScript editor. The current issue causes the button to remain in a gold-colored state after clicking on reset code button, contrary to the expected behavior. Additionally, the functionality requires users to click twice to return to the help mode, which is not the intended behavior
Music.Blocks.is.a.collection.of.tools.for.exploring.fundamental.musical.concepts.in.a.fun.way.-.Google.Chrome.2024-01-11.00-04-55.mp4