Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for accessor arrays in blas/ext/base/gsumkbn #4923

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat: add support for accessor arrays in blas/ext/base/gsumkbn #4923

merged 2 commits into from
Jan 29, 2025
+281 −2

Conversation

aayush0325
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds support for accessor arrays in blas/ext/base/gsumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
feat: add accessor array support
5569287 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@aayush0325
Copy link
Member Author

image

i can't understand why the tests for blas/ext/base/gsum are running here

@kgryte
Copy link
Member

kgryte commented Jan 27, 2025

@aayush0325 Because gsumkbn is a dependency of gsum. In order to ensure that changes don't break downstream packages, we need to run the unit tests of those packages.

@aayush0325
Copy link
Member Author

In order to ensure that changes don't break downstream packages, we need to run the unit tests of those packages.

do i need to make any changes here then?

@kgryte
Copy link
Member

kgryte commented Jan 27, 2025

No, but we do need to update the tests in gsum, which hasn't been done, yet, TMK. That can be done in a separate PR. Feel free to make a PR for that; we can merge; then you can update this branch accordingly. See some of Haris' PRs, such as gsumpw, which updated the tests.

@aayush0325 aayush0325 mentioned this pull request Jan 27, 2025
Merged
1 task
@headlessNode
Copy link
Member

@kgryte @aayush0325 FWIW, since gsum is dependent on this PR. We can merge this PR and in the #4924 you can add the changes required to docs and tests related to accessors and otherwise.

@kgryte
Copy link
Member

kgryte commented Jan 29, 2025

@aayush0325 Now that #4924 is merged, would you mind merging in the latest changes? This should address the failing unit tests.

kgryte
kgryte approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. labels Jan 29, 2025
@aayush0325 aayush0325 requested a review from kgryte January 29, 2025 20:42
@kgryte kgryte merged commit 3f3edff into stdlib-js:develop Jan 29, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Enhancement Issue or pull request for enhancing existing functionality. Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @kgryte @headlessNode