Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ObjectPostProcessor to the filter in WebAuthnConfigurer #16371

Closed
wants to merge 1 commit into from

Conversation

kse-music
Copy link
Contributor

Closes gh-16369

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 8, 2025
@rwinch
Copy link
Member

rwinch commented Jan 10, 2025

Thanks for the PR @kse-music However, I'd like it split into two features even though it is in a single ticket. This helps us to track changes more accurately.

One of the pull requests would focus on configuring PublicKeyCredentialCreationOptionsRepository. I'd prefer to have a bit more first class support for configuring PublicKeyCredentialCreationOptionsRepository. The configuration should have an explicit property for PublicKeyCredentialCreationOptionsRepository. If it is set, then it should be used. Otherwise, if there is no value set on the DSL, it should look for a unique Bean of type PublicKeyCredentialCreationOptionsRepository. If it exists, then, it should be used.

For the other pull request, it would allow configuring HttpMessageConverter<Object> through the DSL only. This is important because serialization/deserialization should be explicit to avoid accidentally opening up a deserialization vulnerability.

I'm going to close this and if you are able, I'd love to see two PRs split up in that way.

@rwinch rwinch added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 10, 2025
@rwinch rwinch self-assigned this Jan 10, 2025
@rwinch rwinch closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dependency injection in webauthn filters to allow for customization
3 participants