Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAuthnConfigurer HttpMessageConverter Support #16397

Closed
wants to merge 1 commit into from

Conversation

kse-music
Copy link
Contributor

Closes gh-16369

Related to #16371

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 16, 2025
@rwinch rwinch changed the title Set HttpMessageConverter by DSL WebAuthnConfigurer Supports HttpMessageConverter Jan 18, 2025
@rwinch rwinch changed the title WebAuthnConfigurer Supports HttpMessageConverter Add WebAuthnConfigurer HttpMessageConverter Support Jan 18, 2025
@rwinch rwinch added this to the 6.5.0-M1 milestone Jan 18, 2025
rwinch added a commit that referenced this pull request Jan 18, 2025
rwinch added a commit that referenced this pull request Jan 18, 2025
@rwinch rwinch closed this in 4dc1dcb Jan 18, 2025
@rwinch
Copy link
Member

rwinch commented Jan 18, 2025

Thanks for the Pull Request! This is now merged into main via the merge commit 4dc1dcb 😄

I included the original commit as 4dc1dcb that was rebased along with additional polish:

  • 1f98454 Document custom HttpMessageConverter support for WebAuthn
  • a2abe3c Add HttpMessageConverter WebAuthnDsl Support
  • 4dc1dcb WebAuthnConfigurer Supports HttpMessageConverter
  • 5462b4c webauthnWhenConfiguredMessageConverter uses mock
  • 0d4f786 Fix WebAuthnConfigurer Javadoc
  • 8181cec Set HttpMessageConverter by DSL

rwinch added a commit that referenced this pull request Jan 18, 2025
rwinch added a commit that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dependency injection in webauthn filters to allow for customization
4 participants