-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dependency injection in webauthn filters to allow for customization #16369
Labels
Comments
levimiller-qhrtech
added
status: waiting-for-triage
An issue we've not yet triaged
type: enhancement
A general enhancement
labels
Jan 7, 2025
kse-music
added a commit
to kse-music/spring-security
that referenced
this issue
Jan 8, 2025
Closes spring-projectsgh-16369 Signed-off-by: DingHao <[email protected]>
@levimiller-qhrtech Thanks for creating this ticket. I agree with the requests you have made (we will split it into two features though). @kse-music put together a PR, but I asked for some changes. I'm waiting to see if he will make some changes I requested (I'm hopeful he will as he is very active/excellent contributor). |
rwinch
added
in: web
An issue in web modules (web, webmvc)
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jan 10, 2025
kse-music
added a commit
to kse-music/spring-security
that referenced
this issue
Jan 12, 2025
Closes spring-projectsgh-16369 Signed-off-by: DingHao <[email protected]>
kse-music
added a commit
to kse-music/spring-security
that referenced
this issue
Jan 12, 2025
Closes spring-projectsgh-16369 Signed-off-by: DingHao <[email protected]>
kse-music
added a commit
to kse-music/spring-security
that referenced
this issue
Jan 12, 2025
Closes spring-projectsgh-16369 Signed-off-by: DingHao <[email protected]>
rwinch
pushed a commit
that referenced
this issue
Jan 18, 2025
Closes gh-16369 Signed-off-by: DingHao <[email protected]>
Thanks to @kse-music this is now resolved in main! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Expected Behavior
I expect to be able to provide my own implementations for PublicKeyCredentialCreationOptionsRepository and HttpMessageConverter when using passkeys/webauthn, specifically to be able to save/load the options outside of a session.
e.g.,
Current Behavior
The webauthn filters just initialize their own instances on construction:
https://github.com/spring-projects/spring-security/blob/main/web/src/main/java/org/springframework/security/web/webauthn/registration/PublicKeyCredentialCreationOptionsFilter.java#L59
WebAuthnRegistrationFilter at least has a setter to update it, but I'd have to use reflection to update PublicKeyCredentialCreationOptionsFilter.
Context
I have another server forwarding the webauthn requests to a spring boot server, and will be storing the state externally and not in a session. My current workaround is to use reflection to update the private fields to use my implementation of B2cPublicKeyCredentialCreationOptionsRepository, but I feel that dependencies should be injected so they can be customized.
The text was updated successfully, but these errors were encountered: